Skip to content

chore: Add void to mark bootstrap Promise as intentionally not awaited #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Add void to mark bootstrap Promise as intentionally not awaited #338

wants to merge 1 commit into from

Conversation

minhtc-tech
Copy link

  • The npm run lint returns a warning about the bootstrap function inside main.ts.
  • Since this function is being used at the top level of a CommonJS module, we cannot use await here.
  • We should fix it by adding the keyword void to mark the Promise bootstrap function as intentionally not awaited.
  • References: https://typescript-eslint.io/rules/no-floating-promises/#ignorevoid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@minhtc-tech